onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-519389917 What do you think, @rhtyd ? Would a null value check in `VMSnapshotManagerImpl.orchestrateCreateVMSnapshot(VmWorkCreateVMSnapshot work)` be better? Otherwise, the other null checks could be removed completely, as we would never return a null value.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
