kioie opened a new pull request #3556: [WIP] [DO NOT MERGE] Add new "Add 
volume" button, to add volume to VM instance directly
URL: https://github.com/apache/cloudstack/pull/3556
 
 
   ## Description
   <!--- Describe your changes in detail -->
   Volume button to allow user to quickly add volume to a VM instance.
   Also slight edit of createVolumeCmd to allow for direct volume attachment to 
VM.
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to 
reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be 
closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the 
boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   ![Screen Shot 2019-07-30 at 8 31 17 
PM](https://user-images.githubusercontent.com/20902920/62169307-94eef080-b330-11e9-8856-8c732551295b.png)
   
   ![Screen Shot 2019-07-30 at 8 35 08 
PM](https://user-images.githubusercontent.com/20902920/62169326-9e785880-b330-11e9-9de8-148bdea14903.png)
   
   ![Screen Shot 2019-07-30 at 8 35 46 
PM](https://user-images.githubusercontent.com/20902920/62169358-a801c080-b330-11e9-90bc-c3034c7357b6.png)
   Volume already attached to instance
   
   ![Screen Shot 2019-07-30 at 8 37 38 
PM](https://user-images.githubusercontent.com/20902920/62169377-b64fdc80-b330-11e9-98b2-0187396ed153.png)
   Trying to attach Volume to VM instance with snapshots
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to 
-->
   <!-- see how your change affects other areas of the code, etc. -->
   Tested createVolume API
   Tried to attach Volume to VM instance with snapshots
   Tried to attach Volume to VM instance without snapshots
   Tried to attach Volume to running VM
   Tried to attach Volume to stopped VM
   <!-- Please read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to