shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM
ingestion
URL: https://github.com/apache/cloudstack/pull/3606#discussion_r343506010
##########
File path: api/src/main/java/com/cloud/vm/UserVmService.java
##########
@@ -513,4 +513,8 @@ UserVm upgradeVirtualMachine(ScaleVMCmd cmd) throws
ResourceUnavailableException
void collectVmNetworkStatistics (UserVm userVm);
+ UserVm importVM(final DataCenter zone, final Host host, final
VirtualMachineTemplate template, final String instanceName, final String
displayName, final Account owner, final String userData, final Account caller,
final Boolean isDisplayVm, final String keyboard,
Review comment:
There is `importUnmanagedInstance(ImportUnmanagedInstanceCmd)` method in
https://github.com/apache/cloudstack/pull/3606/files#diff-3eaaf9de1645091dff197645123e669cR1018
This method is added in UserVmService to keep all user VM commit in the same
place.
Let me know if there is need for refactoring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
