[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr

Tue, 12 Nov 2019 14:43:17 -0800 

andrijapanicsb edited a comment on issue #3678: vpc: fix acl rule with protocol 
number is not applied correctly in vpc vr
URL: https://github.com/apache/cloudstack/pull/3678#issuecomment-553149936
 
 
   LGTM
   
   tested manually, results below.
   
   Setup:
   
![image](https://user-images.githubusercontent.com/45762285/68716860-7b9f4680-05a5-11ea-9610-c09e7ab48ab3.png)
   
   Results as expected:
   
![image](https://user-images.githubusercontent.com/45762285/68716817-5f9ba500-05a5-11ea-8eaa-5b639d05c674.png)
   
   The only concern I have is that the PORT for the custom protocol is NOT 
honoured, and the rule simply allows any port with ESP protocol (50) or AH (51) 
- will work in sense of connectivity, but perhaps you want to advise 
@weizhouapache  /CC @rhtyd 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to