andrijapanicsb commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-554788542 @svenvogel @rhtyd @PaulAngus - I've just checked/tested the thing and the decision to store the VIRTUAL size (vs. the physical size that we do currently) in the "qcow2.virtualsize" and "virtualsize"" is the correct thing to do. This is exactly what is done when we download a template from i.e. internet into ACS - otherwise, trying to spin a system VM on SF will fail. Now, a few points from my side: - In ideal world, we should make qemu-img a mandatory/dependency binary while installing the "cloudstack-management" binaries and remove that -M flag in this PR, and **ALWAYS** store the VIRTUAL size in those 2 values, irrelevant of what storage is used. - we are refactoring something that has been working ever since (some needless refactoring like putting ELSE in the same line, vs. a new line previously - I really don't see a need to do so) - If you stick to the current PR, then you are relying on having qemu-img installed, so this needs documentation update (I see error messages raised etc) - or do a better solution as I suggested above and make it a dependency and remove the -M flag conditions completely.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
