rhtyd commented on issue #3625: ui allows disabled API call and then ends session URL: https://github.com/apache/cloudstack/issues/3625#issuecomment-557507993 @DaanHoogland okay here are my thoughts: 1 - looks valid, the handler of the call shoud check the API response for errors and only sign out when it's 401 (unauthorised) and not 404 etc. This I think has been handled in Primate where we direct to a 404 page instead of logging out the user here: https://github.com/apache/cloudstack-primate/blob/master/src/utils/request.js#L50 2 - agree, we would need to check what happens wrt the HTTP error code returned and its handling 3 - we probably wouldn't get there, in Primate we reload the UI on 401 and jump to the login page
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
