DaanHoogland commented on a change in pull request #3606: [WIP DO NOT MERGE] VM
ingestion
URL: https://github.com/apache/cloudstack/pull/3606#discussion_r349690207
##########
File path:
server/src/main/java/org/apache/cloudstack/vm/VmImportManagerImpl.java
##########
@@ -233,10 +233,10 @@ private UnmanagedInstanceResponse
createUnmanagedInstanceResponse(UnmanagedInsta
response.setMemory(instance.getMemory());
response.setOperatingSystemId(instance.getOperatingSystemId());
response.setOperatingSystem(instance.getOperatingSystem());
-
response.setObjectName(UnmanagedInstance.class.getSimpleName().toLowerCase());
+ response.setObjectName("unmanagedinstance");
Review comment:
? why this change? I am confused both about the initial code and the changed
code. Seems not important, but still I am interested in naming per sé. What are
the considerations?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
