andrijapanicsb commented on issue #3649: Garbage snapshots are left on Primary and Secondary URL: https://github.com/apache/cloudstack/pull/3649#issuecomment-557736437 Well, things are a bit complicated on XenServer (7.1.0), need some more fix (nothing major I hope) **While backup to secondary = TRUE**, results as follows: - can create snaps - after the snap is created, snap stays on both Primary and Secondary storage (here, incremental/delta snaps are copied to Secondary Storage - and each newer snap is referencing the older snap via the _snapshost_store_ref_ table, the _parent_snapshot_id_ field. - deletion needs to be done from the newest to the oldest snap (climbing in chain so to speak), otherwise deleting a snap in the middle of the chain (when there are multiple snaps) will be reported as failed, will produce partial records in DB, but if you later remove all older snaps in the chain etc - all will come to its place eventually... I assume this is OK/acceptable and potentially an old behaviour - deleting snaps WILL REMOVE them from Sec Storage fine - no garbage - FINE - **deleting snaps WILL NOT REMOVE then from the Primary Storage - here we have garbage left** - when the storage cleanup thread runs, it will remove needed records from DB just fine (inside snapshots_store_ref), both the ones referencing snaps on Primary and on Secondary storage - so this is working FINE for XenServer, but not for KVM - for KVM garbage is left for the rows pointing to Primary Storage (that's the storage cleanup thread that might need some fix for KVM) If garbage that is left on Primary Storage could be fixed, it would be great. Otherwise, I can live with the current situation and I will then raise a new blocker issue in the GitHub (which boils to "let's fix it now") /CC @rhtyd @nvazquez **While backup to secondary = FALSE**, results as follows: - creating a snap will produce a snap just on Primary Storage - FINE **- trying to delete a snap FAILS, identical message as for KVM - "Failed to delete snapshot:java.util.MissingFormatArgumentException: Format specifier '%d'"** - that should be a quick fix hopefully - Can't test if garbage is left on Primary Stor since deletion fails
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
