anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better
tracking host maintanence success and failure
URL: https://github.com/apache/cloudstack/pull/3425#discussion_r349996309
##########
File path: api/src/main/java/com/cloud/resource/ResourceState.java
##########
@@ -92,18 +101,25 @@ public ResourceState getNextState(Event a) {
s_fsm.addTransition(ResourceState.Enabled, Event.Enable,
ResourceState.Enabled);
s_fsm.addTransition(ResourceState.Enabled, Event.InternalCreated,
ResourceState.Enabled);
s_fsm.addTransition(ResourceState.Enabled, Event.Disable,
ResourceState.Disabled);
- s_fsm.addTransition(ResourceState.Enabled, Event.AdminAskMaintenace,
ResourceState.PrepareForMaintenance);
+ s_fsm.addTransition(ResourceState.Enabled, Event.AdminAskMaintenance,
ResourceState.PrepareForMaintenance);
s_fsm.addTransition(ResourceState.Enabled,
Event.InternalEnterMaintenance, ResourceState.Maintenance);
s_fsm.addTransition(ResourceState.Disabled, Event.Enable,
ResourceState.Enabled);
s_fsm.addTransition(ResourceState.Disabled, Event.Disable,
ResourceState.Disabled);
s_fsm.addTransition(ResourceState.Disabled, Event.InternalCreated,
ResourceState.Disabled);
s_fsm.addTransition(ResourceState.PrepareForMaintenance,
Event.InternalEnterMaintenance, ResourceState.Maintenance);
s_fsm.addTransition(ResourceState.PrepareForMaintenance,
Event.AdminCancelMaintenance, ResourceState.Enabled);
- s_fsm.addTransition(ResourceState.PrepareForMaintenance,
Event.UnableToMigrate, ResourceState.ErrorInMaintenance);
+ s_fsm.addTransition(ResourceState.PrepareForMaintenance,
Event.UnableToMigrate, ResourceState.ErrorInPrepareForMaintenance);
+ s_fsm.addTransition(ResourceState.PrepareForMaintenance,
Event.UnableToMaintain, ResourceState.ErrorInMaintenance);
s_fsm.addTransition(ResourceState.PrepareForMaintenance,
Event.InternalCreated, ResourceState.PrepareForMaintenance);
s_fsm.addTransition(ResourceState.Maintenance,
Event.AdminCancelMaintenance, ResourceState.Enabled);
s_fsm.addTransition(ResourceState.Maintenance, Event.InternalCreated,
ResourceState.Maintenance);
s_fsm.addTransition(ResourceState.Maintenance, Event.DeleteHost,
ResourceState.Disabled);
+ s_fsm.addTransition(ResourceState.ErrorInPrepareForMaintenance,
Event.InternalEnterMaintenance, ResourceState.Maintenance);
+ s_fsm.addTransition(ResourceState.ErrorInPrepareForMaintenance,
Event.AdminCancelMaintenance, ResourceState.Enabled);
+ s_fsm.addTransition(ResourceState.ErrorInPrepareForMaintenance,
Event.UnableToMigrate, ResourceState.ErrorInPrepareForMaintenance);
+ s_fsm.addTransition(ResourceState.ErrorInPrepareForMaintenance,
Event.UnableToMaintain, ResourceState.ErrorInMaintenance);
+ s_fsm.addTransition(ResourceState.ErrorInPrepareForMaintenance,
Event.ErrorsCorrected, ResourceState.PrepareForMaintenance);
+ s_fsm.addTransition(ResourceState.ErrorInPrepareForMaintenance,
Event.InternalCreated, ResourceState.ErrorInPrepareForMaintenance);
Review comment:
I looked back and it was previous functionality as well. Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
