rhtyd commented on a change in pull request #3747: convert protocal names to be 
found as labels
URL: https://github.com/apache/cloudstack/pull/3747#discussion_r355147642
 
 

 ##########
 File path: ui/scripts/network.js
 ##########
 @@ -6843,7 +6843,8 @@
             return [];
         }
 
-        var protocols = protocolCapabilities.value.split(',');
+// make sure protocols are found in a script compatible way: i.e. 
"tcp,udp,tcp.proxy" , no minus sign or spaces
 
 Review comment:
   can you fix the comment, add proper indents?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to