sureshanaparti commented on a change in pull request #3638: UEFI Support on
CloudStack
URL: https://github.com/apache/cloudstack/pull/3638#discussion_r356211331
##########
File path:
server/src/main/java/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java
##########
@@ -112,6 +117,16 @@
VMTemplateVO template = (VMTemplateVO)vmProfile.getTemplate();
Account account = vmProfile.getOwner();
+ boolean isVMDeployedWithUefi = false;
+ UserVmDetailVO userVmDetailVO =
_userVmDetailsDao.findDetail(vmProfile.getId(), "UEFI");
+ if(userVmDetailVO != null){
+ if ("secure".equalsIgnoreCase(userVmDetailVO.getValue()) ||
"legacy".equalsIgnoreCase(userVmDetailVO.getValue())) {
Review comment:
define enum globally for boot types & modes (secure and legacy) and use it
across, whenever applicable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
