DaanHoogland commented on a change in pull request #3350: Get Diagnostics:
Download logs and diagnostics data from SSVM, CPVM, Router
URL: https://github.com/apache/cloudstack/pull/3350#discussion_r364273757
##########
File path: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java
##########
@@ -58,6 +58,30 @@ public static void scpTo(String host, int port, String
user, File pemKeyFile, St
scpTo(host, port, user, pemKeyFile, password, remoteTargetDirectory,
data, remoteFileName, fileMode, DEFAULT_CONNECT_TIMEOUT, DEFAULT_KEX_TIMEOUT);
}
+ public static void scpFrom(String host, int port, String user, File
permKeyFile, String localTargetDirectory, String remoteTargetFile) throws
Exception {
Review comment:
there is no issue with this PR but the SshHelper methods throwing a generic
```Exception``` is not a good pattern. At least it should be a
SshHelper-specific wrapper :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
