anuragaw commented on a change in pull request #3350: Get Diagnostics: Download
logs and diagnostics data from SSVM, CPVM, Router
URL: https://github.com/apache/cloudstack/pull/3350#discussion_r364289979
##########
File path: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java
##########
@@ -58,6 +58,30 @@ public static void scpTo(String host, int port, String
user, File pemKeyFile, St
scpTo(host, port, user, pemKeyFile, password, remoteTargetDirectory,
data, remoteFileName, fileMode, DEFAULT_CONNECT_TIMEOUT, DEFAULT_KEX_TIMEOUT);
}
+ public static void scpFrom(String host, int port, String user, File
permKeyFile, String localTargetDirectory, String remoteTargetFile) throws
Exception {
Review comment:
I think it's going to be large effort to fix this pattern as part of this
PR. Given the length of time this PR has been kept open and testing already
done on this code perhaps we can clean up this in a separate PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
