andrijapanicsb commented on issue #3681: Validate disk offering IOPS normal and maximum read/write values URL: https://github.com/apache/cloudstack/pull/3681#issuecomment-573882813 @GabrielBrascher this looks fine. However, I would ask if it makes sense (or not!) to also validate not only the iops burst duration but also bytes rate duration? If not, that's all OK - let me know, please. i.e. > (localcloud) SBCM5> > list configurations name=iops.maximum.rate.length | grep value\" "value": "10" (localcloud) SBCM5> > create diskoffering bytesreadrate=1000 bytesreadratemax=1500 byteswriterate=1000 byteswriteratemax=1500 iopsreadrate=2000 iopsreadratemax=2500 iopswriterate=2000 iopswriteratemax=2500 bytesreadratemaxlength=15 byteswriteratemaxlength=15 iopsreadratemaxlength=15 iopswriteratemaxlength=15 name=xxx displaytext=xxx disksize=1 Error: (HTTP 431, error code 4350) IOPS read max length (15 seconds) cannot be greater than iops.maximum.rate.length (10s seconds) (localcloud) SBCM5> > create diskoffering bytesreadrate=1000 bytesreadratemax=1500 byteswriterate=1000 byteswriteratemax=1500 iopsreadrate=2000 iopsreadratemax=2500 iopswriterate=2000 iopswriteratemax=2500 bytesreadratemaxlength=15 byteswriteratemaxlength=15 iopsreadratemaxlength=15 iopswriteratemaxlength=9 name=xxx displaytext=xxx disksize=1 Error: (HTTP 431, error code 4350) IOPS read max length (15 seconds) cannot be greater than iops.maximum.rate.length (10s seconds) (localcloud) SBCM5> > create diskoffering bytesreadrate=1000 bytesreadratemax=1500 byteswriterate=1000 byteswriteratemax=1500 iopsreadrate=2000 iopsreadratemax=2500 iopswriterate=2000 iopswriteratemax=2500 bytesreadratemaxlength=15 byteswriteratemaxlength=15 iopsreadratemaxlength=9 iopswriteratemaxlength=9 name=xxx displaytext=xxx disksize=1 { "diskoffering": { "created": "2020-01-13T21:37:38+0000", "diskBytesReadRate": 1000, "diskBytesReadRateMax": 1500, "diskBytesReadRateMaxLength": 15, "diskBytesWriteRate": 1000, "diskBytesWriteRateMax": 1500, "diskBytesWriteRateMaxLength": 15, "diskIopsReadRate": 2000, "diskIopsReadRateMax": 2500, "diskIopsReadRateMaxLength": 9, "diskIopsWriteRate": 2000, "diskIopsWriteRateMax": 2500, "diskIopsWriteRateMaxLength": 9, "disksize": 1, "displayoffering": true, "displaytext": "xxx", "id": "3920175d-ee3e-46d4-b25c-3d12fb040d25", "iscustomized": false, "name": "xxx", "provisioningtype": "thin", "storagetype": "shared" } }
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
