wido commented on a change in pull request #3739: Add new command to update
security group name
URL: https://github.com/apache/cloudstack/pull/3739#discussion_r367088181
##########
File path:
server/src/main/java/com/cloud/network/security/SecurityGroupManagerImpl.java
##########
@@ -858,6 +859,10 @@ public SecurityGroupVO
createSecurityGroup(CreateSecurityGroupCmd cmd) throws Pe
Account caller = CallContext.current().getCallingAccount();
Account owner = _accountMgr.finalizeOwner(caller,
cmd.getAccountName(), cmd.getDomainId(), cmd.getProjectId());
+ if (name.trim().equals("")) {
Review comment:
Maybe use the commons check ifNotEmpty? We use this on multiple locations in
the CloudStack code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
