weizhouapache commented on a change in pull request #3808: reload dnsmasq
instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#discussion_r367285872
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##########
@@ -69,7 +69,7 @@ def process(self):
if not self.cl.is_redundant() or self.cl.is_master():
if restart_dnsmasq:
- CsHelper.service("dnsmasq", "restart")
+ CsHelper.service("dnsmasq", "reload")
Review comment:
> I'll need to test this all @weizhouapache , but afaik dnsmasq is started
when VR is created?
@andrijapanicsb it seems dnsmasq is disabled in routers. it will be started
when dnsmasq.conf is generated.
https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/setup/common.sh#L588-L595
> Do you see a problem here? (save me some time from testing all this...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
