GabrielBrascher commented on a change in pull request #3681: Validate disk
offering IOPS normal and maximum read/write values
URL: https://github.com/apache/cloudstack/pull/3681#discussion_r370962823
##########
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -389,6 +389,18 @@
public static final ConfigKey<Boolean> SystemVMUseLocalStorage = new
ConfigKey<Boolean>(Boolean.class, "system.vm.use.local.storage", "Advanced",
"false",
"Indicates whether to use local storage pools or shared storage
pools for system VMs.", false, ConfigKey.Scope.Zone, null);
+ public static ConfigKey<Long> iopsMaximumRateLength = new
ConfigKey<Long>(Long.class, "iops.maximum.rate.length", "Advanced", "0",
+ "Sets the maximum IOPS read/write length (seconds) accepted; thus,
preventing irrealistic values for a disk offering (e.g. hours or days of burst
IOPS)."
+ + " The default value is 0 (zero) and allows any IOPS
maximum rate length."
+ + " Example: iops.maximum.rate.length = 3600 sets the
maximum IOPS length accepted for a disk offering as 3600 seconds (60 minutes).",
+ false, ConfigKey.Scope.Global, null);
+
+ public static ConfigKey<Long> iopsMaximumBytes = new
ConfigKey<Long>(Long.class, "iops.maximum.rate.length", "Advanced", "0",
Review comment:
I don't see any problem on having maximum iops for write and read separately
if this makes sense on a practical way. What do you think @wido?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
