ravening commented on a change in pull request #3807: Enhancement: Allow
creating network with duplicate name
URL: https://github.com/apache/cloudstack/pull/3807#discussion_r371705037
##########
File path: server/src/main/java/com/cloud/network/NetworkServiceImpl.java
##########
@@ -200,9 +203,14 @@
/**
* NetworkServiceImpl implements NetworkService.
*/
-public class NetworkServiceImpl extends ManagerBase implements NetworkService {
+public class NetworkServiceImpl extends ManagerBase implements NetworkService,
Configurable {
private static final Logger s_logger =
Logger.getLogger(NetworkServiceImpl.class);
+ private static final ConfigKey<Boolean> AllowDuplicateNetworkName = new
ConfigKey<Boolean>("Advanced", Boolean.class,
+ "allow.duplicate.networkname", "true", "Allow creating networks
with same name in account", true, ConfigKey.Scope.Account);
+ private static final ConfigKey<Boolean> AllowEmptyStartEndIpAddress = new
ConfigKey<Boolean>("Advanced", Boolean.class,
+ "allow.empty.start.end.ipaddress", "true", "Allow creating network
without mentioning start and end IP address",
+ true, ConfigKey.Scope.Account);
Review comment:
@rhtyd In the current/default behavior we can create network without
mentioning the start and end IP address. So the default value is "true". If the
default value is "false" then it means we cant create a network with an empty
start and end IP address which is not backward compatible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
