DaanHoogland commented on a change in pull request #3847: VR: Fix Redundant
VRouter guest network on wrong interface
URL: https://github.com/apache/cloudstack/pull/3847#discussion_r372330096
##########
File path:
server/src/main/java/com/cloud/network/router/CommandSetupHelper.java
##########
@@ -728,6 +741,13 @@ public int compare(final PublicIpAddress o1, final
PublicIpAddress o2) {
final DataCenterVO dcVo =
_dcDao.findById(router.getDataCenterId());
cmd.setAccessDetail(NetworkElementCommand.ZONE_NETWORK_TYPE,
dcVo.getNetworkType().toString());
+ Boolean lastIp = vlanLastIp.get(vlanTagKey);
+ if (lastIp == null) {
+ cmd.setAccessDetail(NetworkElementCommand.NETWORK_PUB_LAST_IP,
"true");
+ } else {
+ cmd.setAccessDetail(NetworkElementCommand.NETWORK_PUB_LAST_IP,
"false");
+ }
+
Review comment:
here useAccessDetailsAccordingToVlanLastIpForGuestNetwork(); (long names
just to be descriptive
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
