[GitHub] [cloudstack] ravening opened a new pull request #3818: Display numeric value in exception instead of variable name

[GitBox]

ravening opened a new pull request #3818: Display numeric value in exception 
instead of variable name
URL: https://github.com/apache/cloudstack/pull/3818
 
 
   ## Description
   <!--- Describe your changes in detail -->
   If the disk size of the VM to be created is greater
   then the volume size, then the exception message should
   display the numeric value instead of the variable name
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to 
reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be 
closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the 
boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   Below is the exception which is thrown when error happens while creating a VM
   
   ![Screenshot 2020-01-17 at 13 14 
54](https://user-images.githubusercontent.com/10645273/72620185-179b5480-393f-11ea-9754-3366b8605fb2.png)
   
   After the fix, below is the message which is displayed
   
   ![Screenshot 2020-01-17 at 13 18 
29](https://user-images.githubusercontent.com/10645273/72620204-2124bc80-393f-11ea-97b2-d5ad636d8c1c.png)
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to 
-->
   <!-- see how your change affects other areas of the code, etc. -->
   Set the global setting ```custom.diskoffering.size.max``` to lower value and 
try to create a vm with disk size greater the value of setting 
```custom.diskoffering.size.max```
   
   
   <!-- Please read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services