rhtyd commented on a change in pull request #3879: kvm: Enable virtio drivers
based on guest os display name
URL: https://github.com/apache/cloudstack/pull/3879#discussion_r379269036
##########
File path: server/src/main/java/com/cloud/hypervisor/KVMGuru.java
##########
@@ -132,7 +132,7 @@ public VirtualMachineTO implement(VirtualMachineProfile
vm) {
guestOsMapping =
_guestOsHypervisorDao.findByOsIdAndHypervisor(guestOS.getId(),
getHypervisorType().toString(), host.getHypervisorVersion());
}
if (guestOsMapping == null || host == null) {
- to.setPlatformEmulator("Other");
+ to.setPlatformEmulator(guestOS.getDisplayName());
Review comment:
@ustcweizhou how about we check and fallback to `"Other"` in case
`guestOS.getDisplayName()` is null or empty (unlikely but just to make code
more defensive)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
