ustcweizhou opened a new pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat URL: https://github.com/apache/cloudstack/pull/3902 ## Description <!--- Describe your changes in detail --> This PR aims to fix the issue below 1. Create a network offering for isolated network, services: Dns/Dhcp/Userdata, and enable it 2. create a isolated network with the new offering 3. create a vm 4. check the guest IP of virtual router, 5. restart network with cleanup 6. check the guest IP of new virtual router 7. The IP in step4 and step6 should be the same, but they are different actually. <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> tested with steps above, the IPs are same in step 7. change network to another offering with public ip, the placeholder ip is removed from database. tested with shared networks and L2 network as well. <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
