DaanHoogland commented on issue #3839: FEATURE-3823: kvm agent hooks URL: https://github.com/apache/cloudstack/pull/3839#issuecomment-590115081 > sorry about being slightly nervous about that. This is my fault. That's alright, your frustration is real and understandable but please do not let it take control. > I just would like to add, that initially created an issue #3823 and invited the influencers to participate. You can see the thread - the answer is "oh, we have that", without the deeper thoughts and design discussion ... silence. Next, I created a PR and again "oh, we have that"... Well, I know it's open-source, but I believe it is nice to have a piece of attention to community efforts. I know and I understand that your requirements were not met by that other PR. If you PR does not cause any regressiion we should probably merge it (imnsho). I do want to see how it doubles technical implementation with the rolling maintenance for KVM however. And maybe with other PRs. We should try to unify the efforts. if not before merging than certainly in the future. @weizhouapache is going to test the patch for regressions as he wants it in (he runs a public cloud!). if he gives his ok, we can merge. > So, my PR is #3839 > Compared PR is #3510 yes, i guessed so much. > Now not a lot of companies use CS as a public-cloud platform, so may efforts are private cloud, corporate-centric. I suppose this is the reason why #3823 is not understood properly. But it's very useful for people who use CS beyond the release-implemented features. Now this is not true. I do not know the exact numbers but neither the number of public clouds nor the number of private/enterprise installations is very low. For the benelux/france region they are about the same I would say. As for the functionality I am still to understand a few things; How do administrators enter or change hooks? Do they have to go to the host? Is there a way to control the functionality from management server? I have some remarks on code style as well. Noticeable the code added is added to existing methods, growing sizes and complexity. I would like to see the new code in separate methods. This is not a breakpoint!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
