bwsw commented on a change in pull request #3839: FEATURE-3823: kvm agent hooks
URL: https://github.com/apache/cloudstack/pull/3839#discussion_r386197715
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -284,6 +284,18 @@
protected String _rngPath = "/dev/random";
protected int _rngRatePeriod = 1000;
protected int _rngRateBytes = 2048;
+ protected String _agentHooksBasedir = "/etc/cloudstack/agent/hooks";
Review comment:
@rhtyd no it's not exactly what does qemu-hooks:
1. there is no qemu hook to override XML
2. qemu hooks deadlocks in certain cases (for onStart/onStop):
```
A hook script must not call back into libvirt, as the libvirt daemon is
already waiting for the script to exit.
A deadlock is likely to occur.
```
From: https://www.libvirt.org/hooks.html
So, libvirt qemu hooks are pretty tough stuff:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
