GabrielBrascher commented on a change in pull request #3911: kvm: fix/optimize
propogating configs
URL: https://github.com/apache/cloudstack/pull/3911#discussion_r388063139
##########
File path:
core/src/main/java/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
##########
@@ -319,9 +319,12 @@ private Answer execute(GetDomRVersionCmd cmd) {
}
public boolean configureHostParams(final Map<String, String> params) {
- if (_params.get("router.aggregation.command.each.timeout") == null) {
+ if (_params.get("router.aggregation.command.each.timeout") != null) {
String value =
(String)params.get("router.aggregation.command.each.timeout");
- _eachTimeout =
Duration.standardSeconds(NumbersUtil.parseInt(value, 10));
+ _eachTimeout =
Duration.standardSeconds(NumbersUtil.parseLong(value, 600));
Review comment:
I am +1 on externalizing 600 into a constant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
