GabrielBrascher commented on issue #3681: Validate disk offering IOPS normal and maximum read/write values URL: https://github.com/apache/cloudstack/pull/3681#issuecomment-597114256 Hi @borisstoyanov , thanks for testing this PR. The global settings affect the following disk offering parameters: ``` bytesreadratemaxlength byteswriteratemaxlength iopsreadratemaxlength iopswriteratemaxlength ``` The setup on global settings are according to the following parameters: ``` vm.disk.bytes.maximum.read.length = 0 vm.disk.bytes.maximum.write.length = 0 vm.disk.iops.maximum.read.length = 0 vm.disk.iops.maximum.write.length = 0 ``` Quick resume on the length parameters. The verifications ensure that either Bytes or IOPS bursts cannot be greater than a configured value of those global settings variables. Additionally, this PR checks the normal IOPS (write/read) ensuring that it cannot be higher than the respective maximum value (if the maximum has been set by the operator, otherwise, if null, it ignores the maximum). Example of all parameters necessary to check if length (e.g. bytesreadratemaxlength) and normal (e.g. bytesreadrate) vs maximum (bytesreadratemax) are OK: - Bytes (read / right) ``` bytesreadrate, bytesreadratemax, bytesreadratemaxlength byteswriterate, byteswriteratemax, byteswriteratemaxlength ``` - IOPS (read / right) ``` iopsreadrate, iopsreadratemax, iopsreadratemaxlength iopswriterate, iopswriteratemax, iopswriteratemaxlength ``` Therefore, the test that you presented should indeed accept the deploy as you have done (no length neither maximum IOPS/bytes have been configured via the disk offering command). Once again, thanks for checking this PR, in case of any question just ping me.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
