davidjumani commented on a change in pull request #3967: noVNC console
integration
URL: https://github.com/apache/cloudstack/pull/3967#discussion_r399053191
##########
File path: server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java
##########
@@ -478,7 +481,12 @@ private String composeConsoleAccessUrl(String rootUrl,
VirtualMachine vm, HostVO
param.setClientTunnelSession(parsedHostInfo.third());
}
- sb.append("/ajax?token=" +
encryptor.encryptObject(ConsoleProxyClientParam.class, param));
+ if (param.getHypervHost() != null ||
!ConsoleProxyManager.NoVncConsoleDefault.value()) {
+ sb.append("/ajax?token=" +
encryptor.encryptObject(ConsoleProxyClientParam.class, param));
+ } else {
+ sb.append("/resource/noVNC/vnc_lite.html?port=" +
ConsoleProxyManager.DEFAULT_NOVNC_PORT + "&token="
Review comment:
Wanted a simpler, minimalist UI, can add this when we get multi lingual
keyboard working
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
