DaanHoogland commented on a change in pull request #4021:
URL: https://github.com/apache/cloudstack/pull/4021#discussion_r418567776
##########
File path:
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -1315,6 +1324,30 @@ public void orchestrateStart(final String vmUuid, final
Map<VirtualMachineProfil
}
}
+ private void logBootModeParameters(Map<VirtualMachineProfile.Param,
Object> params) {
+ StringBuffer msgBuf = new StringBuffer("Uefi params ");
+ boolean log = false;
+ if (params.get(VirtualMachineProfile.Param.UefiFlag) != null) {
+ msgBuf.append(String.format("UefiFlag: %s ",
params.get(VirtualMachineProfile.Param.UefiFlag)));
+ log = true;
+ }
+ if (params.get(VirtualMachineProfile.Param.BootType) != null) {
+ msgBuf.append(String.format("Boot Type: %s ",
params.get(VirtualMachineProfile.Param.BootType)));
+ log = true;
+ }
+ if (params.get(VirtualMachineProfile.Param.BootMode) != null) {
+ msgBuf.append(String.format("Boot Mode: %s ",
params.get(VirtualMachineProfile.Param.BootMode)));
+ log = true;
+ }
+ if (params.get(VirtualMachineProfile.Param.BootIntoSetup) != null) {
+ msgBuf.append(String.format("Boot into Setup: %s ",
params.get(VirtualMachineProfile.Param.BootIntoSetup)));
+ log = true;
+ }
+ if (log) {
+ s_logger.info(msgBuf.toString());
Review comment:
actually the initial text would have to be added so the logic would
replace teh guard boolean with a string concatenation. I prefer this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
