artem-smotrakov commented on a change in pull request #4065:
URL: https://github.com/apache/cloudstack/pull/4065#discussion_r422650520



##########
File path: 
api/src/main/java/org/apache/cloudstack/api/command/user/loadbalancer/UploadSslCertCmd.java
##########
@@ -76,6 +76,9 @@
     @Parameter(name = ApiConstants.NAME , type = CommandType.STRING, required 
= true, description = "Name for the uploaded certificate")
     private String name;
 
+    @Parameter(name = ApiConstants.ENABLED_REVOCATION_CHECK, type = 
CommandType.BOOLEAN, description = "Enables revocation checking for 
certificates")

Review comment:
       @DaanHoogland Do you mean `since` parameter for the `@Parameter` 
annotation?
   
   ```@Parameter(..., since = "4.14" ...)```
   
   Or, do you mean `@since` in javadoc?
   
   Which version should it be? 4.14?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to