ravening opened a new pull request #4078:
URL: https://github.com/apache/cloudstack/pull/4078
## Description
1. When SSVM is destroyed the downloaded urls of
template and volumes are not cleaned and because
of that we cant download the templates/volumes
using the download_url link
2. cleanup volumes in secondary storage when ssvm is destroyed
3. It should clean up the download urls for the templates belonging to the
zone where ssvm is running
Steps to test
Before the fix
(1) download template (check download_url in template_store_ref table).
(2) destroy ssvm
(3) download template again
(4) It will fail to download
After the fix
1. Download template
2. Destroy ssvm
3. This will cleanup the download_url in template_store_ref table
4. Try to download template again
5. Download will be successful
Test case 2
Before the fix
1. create a vm
2. stop a vm
3. download volume
Volume stored in
https://10.1.1.2/userdata/2dc15926-eaa4-49f8-9d3c-e71bdbe9d39f.qcow2
4. start/stop ssvm
5. start/stop vm
6. download volume
Volume stored in
https://10.1.1.2/userdata/2dc15926-eaa4-49f8-9d3c-e71bdbe9d39f.qcow2
Expected result
volumes in step3 and step 5 are different
Actual result
volumes in step 3 and 5 are same.
After the fix
volumes in step 3 and 5 are different
step 3: http://10.11.1.2/userdata/7237c056-2a45-426b-b12e-13da9adab644.qcow2
Step 5: http://10.11.1.2/userdata/9da05f2a-2abc-42b8-9adc-c0e41f36f0c4.qcow2
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to
reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be
closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the
boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
