svenvogel commented on a change in pull request #4070:
URL: https://github.com/apache/cloudstack/pull/4070#discussion_r425820747
##########
File path: setup/bindir/cloud-set-guest-password.in
##########
@@ -26,25 +26,58 @@
# Modify this line to specify the user (default is root)
user=root
-# Add your DHCP lease folders here
-DHCP_FOLDERS="/var/lib/dhclient/* /var/lib/dhcp3/* /var/lib/dhcp/*"
+# Add network provider variables here (default means that interface for
network manager is eth0)
+NETPLAN=/etc/netplan
+IFUPDOWN=/etc/network/interfaces
+NETMAN=/etc/sysconfig/network-scripts/ifcfg-eth0
Review comment:
@dimsijul
> Hi Sven,
>
> I see what you mean. Yes, I'll do the change to base the detection on the
folder. I think the same kind of issue would apply to the netplan command
though, if the interface is not declared as eth0 in the netplan config...
sounds good.
> Also, I think that maybe we should do the same as the account to target in
:
>
> Modify this line to specify the user (default is root)
> user=root
>
> with maybe :
>
> Modify this line to specify the network interface (default is eth0)
> netinterface=eth0
>
> and use that variable in netplan and nmcli commands.
>
> What do you think ?
~~maybe i thread lost... what do you mean with modify user=root and
netinterface=eth0... maybe you can ... you mean to specify the first
interface?~~
i see what you mean. yes we should use a variable for the interface but
maybe its better to grep the interface. we dont send the interface to the
machine so we need to find it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
