Spaceman1984 commented on a change in pull request #4084:
URL: https://github.com/apache/cloudstack/pull/4084#discussion_r436520983
##########
File path:
engine/components-api/src/main/java/com/cloud/capacity/CapacityManager.java
##########
@@ -73,16 +73,26 @@
"If set to true, creates VMs as full clones on ESX
hypervisor",
true,
ConfigKey.Scope.StoragePool);
- static final ConfigKey<Integer> ImageStoreNFSVersion =
+ static final ConfigKey<Integer> ImageStoreNFSMajorVersion =
Review comment:
@rhtyd If I was to split on `.` I would have to change the Integer data
type to String, basically undoing all the changes I have made. Doing it this
way preserves backward compatibility if a value has already been stored for NFS
version and adding a second variable for minor version is as per the suggestion
in the original issue.
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -831,8 +832,12 @@ protected String mount(String path, String parent, Integer
nfsVersion) {
String result = null;
Script command = new Script(true, "mount", _timeout, s_logger);
command.add("-t", "nfs");
- if (nfsVersion != null){
- command.add("-o", "vers=" + nfsVersion);
+ if (nfsMajorVersion != null){
+ String nfsVersion = "vers=" + nfsMajorVersion;
+ if (nfsMinorVersion != null && nfsMajorVersion >= 4) {
Review comment:
This code does exactly that, I don't understand what you would want to
change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
