shwstppr commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r438561981
##########
File path: python/bindir/cloud-grab-dependent-library-versions
##########
@@ -27,7 +27,7 @@ def runCmd(cmds):
stdout, stderr = process.communicate()
if process.returncode != 0:
raise Exception(stderr)
- return stdout
+ return stdout.decode('utf-8')
Review comment:
@GabrielBrascher centos8 has python2 as python2 python3 as python36 and
centos7 has python2 as python and python3 as python3 so I've added condition
for that in the script.
Though I'm not sure where that script is used. Could see it getting installed
https://github.com/apache/cloudstack/pull/4068/commits/41a69cb3d985b55f76d1f47b51aae34b60e61763
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
