rhtyd commented on a change in pull request #4071:
URL: https://github.com/apache/cloudstack/pull/4071#discussion_r439285205
##########
File path:
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41400to41500.java
##########
@@ -235,6 +238,267 @@ private void updateSystemVmTemplates(final Connection
conn) {
LOG.debug("Updating System Vm Template IDs Complete");
}
+ private void addRolePermissionsForNewReadOnlyAndSupportRoles(final
Connection conn) {
+ addRolePermissionsForReadOnlyAdmin(conn);
+ addRolePermissionsForReadOnlyUser(conn);
+ addRolePermissionsForAdminSupport(conn);
+ addRolePermissionsForUserSupport(conn);
Review comment:
Minor nit - can we call the role 'SupportAdmin' and 'SupportUser'?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
