rhtyd commented on a change in pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#discussion_r441234854
##########
File path: server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java
##########
@@ -481,4 +488,14 @@ public TemplateResponse newIsoResponse(TemplateJoinVO iso)
{
return new Pair<List<TemplateJoinVO>, Integer>(objects, count);
}
+ @Override
+ public List<TemplateJoinVO> findByDistinctIds(Long... ids) {
+ if (ids.length == 0) {
Review comment:
@davidjumani make it defensive, for example do a null check on ids
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
