GabrielBrascher commented on a change in pull request #4212:
URL: https://github.com/apache/cloudstack/pull/4212#discussion_r456015927
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -5619,7 +5619,7 @@ public VirtualMachine migrateVirtualMachine(Long vmId,
Host destinationHost) thr
throw new InvalidParameterValueException("Unsupported Hypervisor
Type for User VM migration, we support XenServer/VMware/KVM/Ovm/Hyperv/Ovm3
only");
}
- if (isVMUsingLocalStorage(vm)) {
+ if (isVMUsingLocalStorage(vm.getId())) {
if (s_logger.isDebugEnabled()) {
s_logger.debug(vm + " is using Local Storage, cannot migrate
this VM.");
Review comment:
@wido I think that I answered the _wrong_ question on previous comments
... Did you mention the `isDebugEnabled()`, or the debug message content?
Regarding the `isDebugEnabled()`, personally, I would remove it. The idea
behind it would be to avoid costly String operations and therefore optimize
CloudStack processing. However, I think that there is a little optimization,
and most of the cases CloudStack already runs in Debug mode.
I think that I saw @DaanHoogland and @rafaelweingartner discussing it in the
past.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
