DaanHoogland commented on a change in pull request #3997:
URL: https://github.com/apache/cloudstack/pull/3997#discussion_r463187096
##########
File path:
engine/components-api/src/main/java/com/cloud/configuration/ConfigurationManager.java
##########
@@ -220,6 +220,11 @@ Vlan createVlanAndPublicIpRange(long zoneId, long
networkId, long physicalNetwor
String vlanGateway, String vlanNetmask, String vlanId, boolean
bypassVlanOverlapCheck, Domain domain, Account vlanOwner, String startIPv6,
String endIPv6, String vlanIp6Gateway, String vlanIp6Cidr)
throws InsufficientCapacityException, ConcurrentOperationException,
InvalidParameterValueException;
+ /* (non-Javadoc)
+ * @see
com.cloud.configuration.ConfigurationManager#updateVlanAndPublicIpRange(long,String,String,String,String)
Review comment:
non javadoc but with a javadoc annotation?
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/UpdateVlanIpRangeCmd.java
##########
@@ -0,0 +1,158 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.vlan;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.VlanIpRangeResponse;
+import org.apache.log4j.Logger;
+
+import com.cloud.dc.Vlan;
+import com.cloud.event.EventTypes;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.user.Account;
+import com.cloud.utils.net.NetUtils;
+
+@APICommand(name = UpdateVlanIpRangeCmd.APINAME, description = "Updates a VLAN
IP range.", responseObject =
+ VlanIpRangeResponse.class, since = "4.13.0",
Review comment:
better update to 4.15.0
##########
File path: api/src/main/java/com/cloud/configuration/ConfigurationService.java
##########
@@ -272,6 +273,22 @@
Vlan createVlanAndPublicIpRange(CreateVlanIpRangeCmd cmd) throws
InsufficientCapacityException, ConcurrentOperationException,
ResourceUnavailableException,
ResourceAllocationException;
+ /**
+ * Updates the IP address Range for the VLAN on the database, a
+ *
+ * @param cmd
+ * @param vlanId
+ * @param gateway
+ * @param startIP
+ * @param endIP
+ * @param netmask
+ * @throws com.cloud.exception.ConcurrentOperationException
+ * @throws com.cloud.exception.ResourceUnavailableException
+ * @throws com.cloud.exception.ResourceAllocationException
Review comment:
let's not leave unused javadoc annotations
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
