weizhouapache commented on pull request #3946: URL: https://github.com/apache/cloudstack/pull/3946#issuecomment-696315331
> LGTM. Tested in a local env. > > * [x] Adding new compute offering and setting it in new global setting results in VR using default offering > * [x] Adding new system service offering for routers and setting it in new global setting results in VR using new offering > * [x] Setting global setting empty results in VR using default offering as expected > > Test failures don't seem related. Will be great if we can have corresponding doc PR for user documentation if not there already @weizhouapache @shwstppr thanks for testing. Will add doc if this is merged. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
