rhtyd commented on a change in pull request #4361:
URL: https://github.com/apache/cloudstack/pull/4361#discussion_r498069859
##########
File path: server/src/main/java/com/cloud/api/ApiDBUtils.java
##########
@@ -1568,7 +1568,7 @@ public static GuestOSCategoryVO
findGuestOsCategoryById(long catId) {
}
public static VpcVO findVpcById(long vpcId) {
- return s_vpcDao.findById(vpcId);
+ return s_vpcDao.findByIdIncludingRemoved(vpcId);
Review comment:
Could this have side effects? You may need to check, or instead add a
new method that finds VPC by ID including removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
