davidjumani commented on a change in pull request #4375:
URL: https://github.com/apache/cloudstack/pull/4375#discussion_r505231606
##########
File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java
##########
@@ -1275,19 +1275,20 @@ private HypervisorType getHypervisorType(VMInstanceVO
vm, StoragePool srcVolumeP
final Type hostType = srcHost.getType();
Pair<List<HostVO>, Integer> allHostsPair = null;
List<HostVO> allHosts = null;
+ List<HostVO> hostsWithStorageMigration = null;
Review comment:
Previously the `allHosts` list was altered (if storage migration was
required) and then used to find the suitable hosts. Instead, now it's being
cloned into `hostsWithStorageMigration` and using the cloned list to find the
suitable hosts so that the original list is not altered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
