GabrielBrascher opened a new pull request #4409:
URL: https://github.com/apache/cloudstack/pull/4409
This PR adds the ability to update the following disk offering fields
- cache-mode,
- IOPS (Read/Write) Rate / IOPS (Read/Write) Rate Max / IOPS (Read/Write)
Rate Max Length
Bytes (Read/Write) Rate /
- Bytes (Read/Write) Rate Max / Bytes (Read/Write) Rate Max Length
## Description
<!--- Describe your changes in detail -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to
reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be
closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the
boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to
-->
<!-- see how your change affects other areas of the code, etc. -->
1. Execute multiple API requests updating different combinations with the
included (13) parameters.
2. Assert that all parameters got updated on DB accordingly.
3. Ensure that IOPS/Bytes validations are properly done, e.g. expected
Exceptions such as `Bytes Write rate (5000) cannot be greater than Bytes Write
maximum rate (3000)`.
<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
