GabrielBrascher commented on a change in pull request #4341:
URL: https://github.com/apache/cloudstack/pull/4341#discussion_r510187219



##########
File path: 
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
##########
@@ -126,6 +126,9 @@
     @Parameter(name = ApiConstants.SERVICE_OFFERING_DETAILS, type = 
CommandType.MAP, description = "details for planner, used to store specific 
parameters")
     private Map details;
 
+    @Parameter(name = ApiConstants.ROOT_DISK_SIZE, type = CommandType.LONG, 
required = false, description = "the Root disk size in GB.")

Review comment:
       Sounds like a good place to add `since` ;)
   Thanks for the heads up @ravening!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to