GabrielBrascher commented on a change in pull request #4418:
URL: https://github.com/apache/cloudstack/pull/4418#discussion_r510305873
##########
File path:
server/src/main/java/org/apache/cloudstack/outofbandmanagement/PowerOperationTask.java
##########
@@ -17,16 +17,26 @@
package org.apache.cloudstack.outofbandmanagement;
+import com.cloud.event.ActionEventUtils;
+import com.cloud.event.EventTypes;
+import com.cloud.event.EventVO;
import com.cloud.host.Host;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.cloudstack.framework.config.ConfigKey;
+import org.apache.cloudstack.framework.config.Configurable;
import org.apache.log4j.Logger;
-public class PowerOperationTask implements Runnable {
+public class PowerOperationTask implements Runnable, Configurable {
public static final Logger LOG =
Logger.getLogger(PowerOperationTask.class);
final private OutOfBandManagementService service;
final private Host host;
final private OutOfBandManagement.PowerOperation powerOperation;
+ public static final ConfigKey<Boolean> CREATE_EVENT_ON_OOBM_FAILURE = new
ConfigKey<Boolean>("Advanced", Boolean.class, "create.event.on.oob.failure",
"true",
Review comment:
Thanks for the suggestion, @wido.
I am removing that global settings config key. There are too many config
keys already, I am leaving to add a new one only if it is really necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
