DaanHoogland commented on pull request #4388: URL: https://github.com/apache/cloudstack/pull/4388#issuecomment-719427756
> > > code LGTM, haven't tested. Please ensure these changes doesn't cause any regression for managed / unmanaged / local storage. > > > > > > @sureshanaparti please explain your concerns or ensure what you can? I'm am trusting @slavkap to have validated any configuration she has access too. If you know what to do more please do so or ping the people that can. If we leave it at this I'm pretty sure no follow up will happen. > > @DaanHoogland the code changes will impact the volume stats for all storage pools. So, it is better if this can be tested with volume(s) on unmanaged, managed and local storage. Otherwise, can cause regression. I understood that, @sureshanaparti. But by who and how should this be tested to appease your concerns. @slavkap, can you explain more about your testing. You claim you have tested with zone wide NFS storage. - Is that all? - have you tested with more types of environement? Or have you @GabrielBrascher ? - is there any reason to think we don't need to test local - or managed storage , @slavkap ? tnx all ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
