DaanHoogland commented on pull request #4445: URL: https://github.com/apache/cloudstack/pull/4445#issuecomment-722998261
I think doing this in java is error prone. if the domain is marked removed it doesn't hurt to keep the details around and if the domain records is actually removed it should be removed with a cascading delete. the only possible reason to do it this way is if we have other 'child' records to domain that we do want to keep when domains are deleted. if you look at DomainDaoImpl.remove(..), you'll find that any checks needed are done there. I think this cleanup should happen there as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
