olivierlemasle commented on a change in pull request #4327:
URL: https://github.com/apache/cloudstack/pull/4327#discussion_r518663324
##########
File path: server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
##########
@@ -2238,4 +2245,18 @@ public boolean
isIpEqualsGatewayOrNetworkOfferingsEmpty(Network network, String
}
return false;
}
+
+ @Override
+ public boolean isUsageHidden(IPAddressVO ip) {
+ Long networkId = ip.getAssociatedWithNetworkId();
+ if (networkId == null) {
+ networkId = ip.getSourceNetworkId();
+ }
+ if (networkId == null) {
+ // Should not happen
Review comment:
@DaanHoogland You're right, I could certainly return a
`CloudRuntimeException`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
