sureshanaparti commented on a change in pull request #4425:
URL: https://github.com/apache/cloudstack/pull/4425#discussion_r521158220
##########
File path:
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
##########
@@ -553,6 +553,25 @@ private void postCreateRecurringSnapshotForPolicy(long
userId, long volumeId, lo
}
}
+ public void markFailedSnapshot(long snapshotId) {
+ Account caller = CallContext.current().getCallingAccount();
+
+ // Verify parameters
+ SnapshotVO snapshotCheck = _snapshotDao.findById(snapshotId);
+
+ if (snapshotCheck == null) {
+ throw new InvalidParameterValueException("unable to find a
snapshot with id " + snapshotId);
+ }
+
+ _accountMgr.checkAccess(caller, null, true, snapshotCheck);
+
+ snapshotCheck.setState(Snapshot.State.Error);
Review comment:
> Not sure what you mean @sureshanaparti
@Spaceman1984 the caller of _copyAsync_ method would set a callback method
to process the result and set the object state accordingly. Can you use that
callback method (of snapshot copy operation) to set the state, through the
event (check the snapshot state machine) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
