sureshanaparti commented on pull request #4078: URL: https://github.com/apache/cloudstack/pull/4078#issuecomment-729643872
> > > > > > @ravening can you deal with the comment or should we move to a later milestone? > > > > > > > > > > > > > > > @DaanHoogland there is no need for functional change. It's a different opinion on coding style. > > > > > > > > > > > > I am not talking about extracting that block of code, I asked you to. Both @rhtyd and @sureshanaparti raised concerns. > > > > > > > > > @DaanHoogland will look into it today > > > > > > while you're at it, can you extract that code block, please? > > @DaanHoogland @sureshanaparti made changes. Please review them again changes LGTM. @ravening can you respond to the comment on multiple SSVMs scenario ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
