DaanHoogland commented on a change in pull request #4525:
URL: https://github.com/apache/cloudstack/pull/4525#discussion_r539289790
##########
File path:
plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
##########
@@ -1489,27 +1489,31 @@ protected String deleteSnapshotBackup(final Connection
conn, final Long dcId, fi
return result;
}
- public void destroyPatchVbd(final Connection conn, final String vmName)
throws XmlRpcException, XenAPIException {
+ public void ejectPatchVbd(final Connection conn, final Host host) {
+ try {
+ final Set<VM> vms = host.getResidentVMs(conn);
+ for (final VM vm : vms) {
+ destroyPatchVbd(conn, vm);
+ }
+ } catch (XenAPIException | XmlRpcException ignored) {}
Review comment:
can we ignore this completely (without at least diagnostic debug
message)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
