DK101010 commented on a change in pull request #4399:
URL: https://github.com/apache/cloudstack/pull/4399#discussion_r542425716



##########
File path: engine/schema/src/main/java/com/cloud/host/HostVO.java
##########
@@ -740,6 +743,18 @@ public void setUuid(String uuid) {
         this.uuid = uuid;
     }
 
+    public boolean checkHostServiceOfferingTags(ServiceOffering 
serviceOffering){
+        if (serviceOffering == null) {
+            return false;
+        }
+        if (Strings.isNullOrEmpty(serviceOffering.getHostTag())) {

Review comment:
       @DaanHoogland Is ok, I think I will survive this :D
   This method was not my idea, it was a part of the old implementation and I 
thought it was nice, so I reused this.
   
   I will change it ;)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to